Skip to content

Adding Google Cloud Memorystore sample #1474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 9, 2018
Merged

Adding Google Cloud Memorystore sample #1474

merged 4 commits into from
May 9, 2018

Conversation

jabubake
Copy link
Contributor

@jabubake jabubake commented May 8, 2018

No description provided.

@jabubake jabubake added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label May 8, 2018
@jabubake jabubake requested a review from andrewsg May 8, 2018 20:28
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 8, 2018
@@ -0,0 +1,16 @@
# Getting started with Googe Cloud Memorystore
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can automatically generate READMEs using our README templater, assuming this isn't a special case. Please reach out to me or Jon for help using it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would be perfect. Please let me know how to do that

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed we'll address this in a follow-up CL to not block the docs rolling out today.

@andrewsg andrewsg removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label May 9, 2018
@andrewsg andrewsg merged commit 79c3f79 into master May 9, 2018
@jabubake jabubake deleted the memorystore branch May 9, 2018 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants