Skip to content

fix(compute): resolve test failures (secondary disk, image family updates) #13614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
+9 −4
Open

fix(compute): resolve test failures (secondary disk, image family updates) #13614

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7fd38d4
fix(compute): change secondary disk creation to match primary
glasnt Oct 20, 2025
3960411
fix(compute): update to latest ubuntu lts
glasnt Oct 20, 2025
a3da12d
correct disk type
glasnt Oct 20, 2025
77053e1
correct image name
glasnt Oct 20, 2025
e9b0a58
add missing disk_type updates from create_secondary_region_disk usage
glasnt Oct 20, 2025
26b6a92
missing commit
glasnt Oct 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions compute/client_library/snippets/tests/test_disks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -447,6 +447,7 @@ def test_create_secondary_region(
PROJECT,
REGION_SECONDARY,
DISK_SIZE,
disk_type="pd-balanced"
)
assert disk.async_primary_disk.disk == autodelete_regional_blank_disk.self_link

Expand All @@ -460,7 +461,7 @@ def test_create_secondary(test_empty_pd_balanced_disk, autodelete_disk_name):
secondary_disk_project=PROJECT,
secondary_disk_zone=ZONE,
disk_size_gb=DISK_SIZE,
disk_type="pd-ssd",
disk_type="pd-balanced",
)
assert disk.async_primary_disk.disk == test_empty_pd_balanced_disk.self_link

Expand All @@ -476,7 +477,7 @@ def test_create_custom_secondary_disk(
secondary_disk_project=PROJECT,
secondary_disk_zone=ZONE,
disk_size_gb=DISK_SIZE,
disk_type="pd-ssd",
disk_type="pd-balanced",
)
assert disk.labels["secondary-disk-for-replication"] == "true"
assert disk.labels["source-disk"] == test_empty_pd_balanced_disk.name
Expand Down Expand Up @@ -504,6 +505,7 @@ def test_start_stop_region_replication(
PROJECT,
REGION_SECONDARY,
DISK_SIZE,
disk_type="pd-balanced"
)
assert start_disk_replication(
project_id=PROJECT,
Expand All @@ -530,6 +532,7 @@ def test_start_stop_zone_replication(test_empty_pd_balanced_disk, autodelete_dis
PROJECT,
ZONE,
DISK_SIZE,
disk_type="pd-balanced"
)
assert start_disk_replication(
project_id=PROJECT,
Expand Down Expand Up @@ -587,6 +590,7 @@ def test_clone_disks_in_consistency_group(
PROJECT,
REGION_SECONDARY,
DISK_SIZE,
disk_type="pd-balanced"
)

add_disk_consistency_group(
Expand Down Expand Up @@ -649,6 +653,7 @@ def test_stop_replications_in_consistency_group(
PROJECT,
REGION_SECONDARY,
DISK_SIZE,
disk_type="pd-balanced"
)
start_disk_replication(
project_id=PROJECT,
Expand Down
2 changes: 1 addition & 1 deletion compute/client_library/snippets/tests/test_instance_from_template.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ def test_create_instance_from_template_override(
image_client = compute_v1.ImagesClient()

image = image_client.get_from_family(
project="ubuntu-os-cloud", family="ubuntu-2004-lts"
project="ubuntu-os-cloud", family="ubuntu-2204-lts"
)
instance = create_instance_from_template_with_overrides(
PROJECT,
Expand Down
2 changes: 1 addition & 1 deletion compute/client_library/snippets/tests/test_instance_suspend_resume.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ def _get_status(instance: compute_v1.Instance) -> compute_v1.Instance.Status:
def compute_instance():
instance_name = "test-instance-" + uuid.uuid4().hex[:10]
newest_debian = get_image_from_family(
project="ubuntu-os-cloud", family="ubuntu-2004-lts"
project="ubuntu-os-cloud", family="ubuntu-2204-lts"
)
disk_type = f"zones/{INSTANCE_ZONE}/diskTypes/pd-standard"
disks = [disk_from_image(disk_type, 100, True, newest_debian.self_link)]
Expand Down