Skip to content

Conversation

lakeyk
Copy link
Contributor

@lakeyk lakeyk commented Aug 26, 2025

feat(genai): Update tuning samples to include automatic evaluations

Description

Fixes #430697448

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

@lakeyk lakeyk requested review from a team as code owners August 26, 2025 00:31
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Aug 26, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @lakeyk, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the 'create tuning job' functionality by integrating automatic evaluation capabilities. It introduces new parameters for validation datasets and evaluation configurations, allowing users to define metrics and output destinations for automated model performance assessment. The API version has also been updated to v1beta1 to support these new features.

Highlights

  • Automatic Evaluation: Enabled automatic evaluation for tuning jobs by introducing evaluation_config.
  • Validation Dataset Support: Added support for specifying a validation_dataset during tuning job creation.
  • API Version Upgrade: Migrated the API client version from v1 to v1beta1 to access newer features.
  • Configurable Metrics: Allowed definition of evaluation metrics, such as 'FLUENCY', within the evaluation_config.
  • GCS Output for Evaluation: Configured the output of evaluation results to a specified GCS bucket.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the tuning job creation samples to include automatic evaluation. The changes introduce new functionality, but I've found a couple of critical issues in both modified files that would prevent the code from running: a missing import for the Metric class and an undefined USER_GCS_FOLDER variable. I've also left a minor comment about indentation to improve code style according to PEP 8. Please address these points to ensure the samples are correct and runnable.

Copy link

@inardini inardini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@msampathkumar msampathkumar changed the title feat: Update create tuning job to include tuning with automatic evalu… feat(genai): Update tuning samples to include automatic evaluations Aug 26, 2025
Copy link
Member

@msampathkumar msampathkumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@msampathkumar msampathkumar merged commit 8421334 into GoogleCloudPlatform:main Aug 26, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants