-
Notifications
You must be signed in to change notification settings - Fork 6.6k
feat(genai): Add new image Generation samples #13549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Local aware & Multiple images generation
Here is the summary of changes. You are about to add 2 region tags.
This comment is generated by snippet-bot.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @msampathkumar, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request significantly expands the genai
library's image generation capabilities by introducing new samples that demonstrate advanced features such as locale-aware image generation and the ability to generate multiple images from a single prompt. Alongside these new additions, the PR includes minor refactorings across existing image generation samples, primarily focusing on standardizing output file paths to a dedicated output_folder
and improving code readability through consistent import statement formatting. These changes aim to provide clearer examples and a more organized structure for image generation outputs.
Highlights
- New Image Generation Samples: Two new image generation samples have been added: one demonstrating locale-aware image generation and another showcasing the ability to generate multiple images from a single prompt using the
gemini-2.0-flash-preview-image-generation
model. - Output Path Standardization: Output file paths across various image generation samples have been standardized to save generated images and related files into a new
output_folder/
directory, improving organization and consistency. - Code Readability Improvements: Import statements in several Python files have been reformatted to use multi-line parentheses, enhancing code readability and adherence to style guidelines.
- Test Suite Enhancements: The test suite has been updated to include comprehensive tests for the newly added image generation samples and to streamline existing test assertions for better maintainability.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds new image generation samples and refactors existing ones. The changes include adding samples for locale-aware generation and multiple image generation. My review focuses on some bugs in the new sample files, specifically incorrect return values and flawed loop logic. I've also pointed out a regression in the test suite where file cleanup and proper assertions have been removed, which could lead to test artifacts and less reliable tests. The formatting changes across multiple files are consistent and improve readability.
Local aware & Multiple images generation
Description
Fixes #
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
nox -s py-3.9
(see Test Environment Setup)nox -s lint
(see Test Environment Setup)