-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(gae): delete samples xmpp, mailjet, mailgun and pubsub in standard folder #13130
chore(gae): delete samples xmpp, mailjet, mailgun and pubsub in standard folder #13130
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi team,
I'm currently reviewing this pull request and will provide my feedback in a few minutes. In the meantime, here's a summary of the changes for you and other reviewers to quickly get up to speed:
This pull request, authored by eapl-gemugami, aims to delete sample applications for XMPP, Mailjet, and Mailgun from the standard App Engine folder. The intent is likely to remove outdated or unnecessary samples, as indicated by the associated internal bug IDs (b/347350844, b/347350951, b/347350275, b/347350679) mentioned in the description.
Here's a breakdown of the changes:
- Deleted Files:
appengine/standard/mailgun/.gitignore
(entire file)appengine/standard/mailgun/README.md
(entire file)appengine/standard/mailgun/app.yaml
(entire file)appengine/standard/mailgun/appengine_config.py
(entire file)appengine/standard/mailgun/main.py
(entire file)appengine/standard/mailgun/main_test.py
(entire file)appengine/standard/mailgun/requirements-test.txt
(entire file)appengine/standard/mailgun/requirements.txt
(entire file)appengine/standard/mailjet/.gitignore
(entire file)appengine/standard/mailjet/README.md
(entire file)appengine/standard/mailjet/app.yaml
(entire file)appengine/standard/mailjet/appengine_config.py
(entire file)appengine/standard/mailjet/main.py
(entire file)appengine/standard/mailjet/main_test.py
(entire file)appengine/standard/mailjet/requirements-test.txt
(entire file)appengine/standard/mailjet/requirements.txt
(entire file)appengine/standard/mailjet/templates/index.html
(entire file)appengine/standard/xmpp/README.md
(entire file)appengine/standard/xmpp/app.yaml
(entire file)appengine/standard/xmpp/requirements-test.txt
(entire file)appengine/standard/xmpp/requirements.txt
(entire file)appengine/standard/xmpp/xmpp.py
(entire file)appengine/standard/xmpp/xmpp_test.py
(entire file)
The author has indicated that the PR should be merged upon approval.
Let me know if you have any questions.
And now for a little haiku to lighten the mood:
Code flows like a stream,
Deleting files, clean and swift,
PR ready to merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull request removes the outdated XMPP, Mailjet, and Mailgun samples from the appengine/standard
directory. Removing outdated samples is good for repository maintainability. It simplifies the codebase and reduces confusion for users. I noticed that the samples for flexible environment are still present. Are these samples also outdated and need to be removed?
Here is the summary of changes. You are about to delete 9 region tags.
This comment is generated by snippet-bot.
|
Description
Fixes Internal:
b/347350844
b/347350275
b/347350679
b/347350796
Checklist