Update modify_policy_add_member.py

[melaniedejong]

Description

Fixes #

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

• I have followed Sample Guidelines from AUTHORING_GUIDE.MD
• README is updated to include all relevant information
• Tests pass: nox -s py-3.9 (see Test Environment Setup)
• Lint pass: nox -s lint (see Test Environment Setup)
• These samples need a new API enabled in testing projects to pass (let us know which ones)
• These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
• This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
• This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
• Please merge this PR for me once it is approved

[ghost]

Hi team,

I'm currently reviewing this pull request and will provide my feedback shortly. In the meantime, here's a summary for you and other reviewers to quickly get up to speed:

This pull request updates the modify_policy_add_member.py sample script. The intent is to improve the clarity and accuracy of the code by renaming the member parameter to principal.

Here's a breakdown of the changes:

• File Changed: iam/cloud-client/snippets/modify_policy_add_member.py
• Changes: The parameter member in the modify_policy_add_member function and its usage in the example code snippet has been renamed to principal. This change aligns the parameter name with the more accurate and widely used term for identifying IAM principals. The change is reflected in both the function definition (lines 21-23 and 37) and the example usage (lines 52-55).

The updated parameter name enhances readability and consistency with Google Cloud IAM documentation, making the sample code easier to understand and use.

I'll be providing a more detailed review shortly.

---

A little haiku to brighten your day:

Code flows like a stream,
Clarity found in each change,
Bugs flee in the night.

[ghost]

This pull request renames the member parameter to principal in the modify_policy_add_member function and its usage. This change improves clarity by using a more accurate term for the entity being granted access. However, there's a minor issue in the test case that needs to be addressed. I've also included some suggestions based on the Google Python Style Guide to enhance code readability and maintainability.

[ghost]

Per the Google Python Style Guide, there should be two blank lines between top-level functions. Add a blank line after the import statements to improve readability.

22:

[ghost]

The variable principal is not defined in this scope. It seems like this should be member based on the previous version of the code. Consider renaming member to principal consistently throughout the code if that's the intended change.

55:    modify_policy_add_member(project_id, role, member)