Skip to content

Conversation

@pavel-salnikov
Copy link
Contributor

@pavel-salnikov pavel-salnikov commented Oct 1, 2024

Description

Fixes the template example and comments:

  • Removed the templated config_file parameter (should point at the usual config with GKE credentials)
  • Updated the Airflow templates reference link
  • Added the comment about templated params
  • Capitalize Kubernetes, Docker
  • Mention namespace param usage for Composer 3
  • Namespace param is not required

Checklist

@pavel-salnikov pavel-salnikov requested a review from kosteev October 1, 2024 10:45
@pavel-salnikov pavel-salnikov requested review from a team as code owners October 1, 2024 10:45
@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: composer Issues related to the Cloud Composer API. labels Oct 1, 2024
Copy link
Contributor

@kosteev kosteev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modulo comments about templated parameters

@iennae iennae merged commit 5fd8e77 into GoogleCloudPlatform:main Oct 1, 2024
11 checks passed
riathakkar pushed a commit to riathakkar/python-docs-samples that referenced this pull request Oct 8, 2024
…dPlatform#12653)

* Remove templated config_file path, fix parameter comments

* Add back templated params info, capitalize Docker
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: composer Issues related to the Cloud Composer API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants