fix(iam): add a print for visibility #12639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
api: iam
rsamborski
approved these changes
Sep 30, 2024
riathakkar
pushed a commit
to riathakkar/python-docs-samples
that referenced
this pull request
Oct 8, 2024
* fix(iam): add a print for visibility * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * Trying to get tests running well * Trying to get tests running well * lint fix --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Maciej Strzelczyk <strzelczyk@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
providing an example to share with folks who worked on these samples, but there is a number of feedback items on samples of "this sample doesn't do anything".
I think an underlying issue is that while the snippet does what it's documented to do, there is no output so the sample doesn't appear to do anything. i.e., output looks like
WARNING: All log messages before absl::InitializeLog() is called are written to STDERR
I0000 00:00:1727410693.815942 2970 config.cc:230] gRPC experiments enabled: call_status_override_on_cancellation, event_engine_dns, event_engine_listener, http2_stats_fix, monitoring_experiment, pick_first_new, trace_record_callops, work_serializer_clears_time_cache
For this sample
With this update it will print out the policy to screen so folks can see that it's doing something. I suspect that there are a lot of samples that need to get some kind of treatment so that there is reduced Feedback.