Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(generative-ai): Cleaning samples - Group A (Controlled Generation, Embeddings, Extensions, Function Calling) #12635

Merged
merged 4 commits into from
Oct 1, 2024

Conversation

Thoughtseize1
Copy link
Contributor

@Thoughtseize1 Thoughtseize1 commented Sep 26, 2024

Description

Cleaning Samples after refactoring Group A

Related PR's:

Feature Name PR Link
Controlled Generation PR#12573
Embeddings PR#12575
Extensions PR#12587
Function Calling PR#12591

Checklist

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Sep 26, 2024
# Conflicts:
#	generative_ai/chat_completions/chat_completions_function_calling_config.py
#	generative_ai/controlled_generation/response_mime_type.py
#	generative_ai/controlled_generation/response_schema.py
#	generative_ai/function_calling.py
@Thoughtseize1 Thoughtseize1 changed the title fix: Cleaning samples - Group A refactor: Cleaning samples - Group A Sep 26, 2024
@msampathkumar msampathkumar self-assigned this Sep 26, 2024
@Thoughtseize1 Thoughtseize1 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 26, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 26, 2024
@msampathkumar msampathkumar changed the title refactor: Cleaning samples - Group A refactor(generative-ai): Cleaning samples - Group A (Controlled Generation, Embeddings, Extensions, Function Calling) Sep 26, 2024
@msampathkumar msampathkumar added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 26, 2024
@msampathkumar msampathkumar marked this pull request as ready for review September 26, 2024 17:23
@msampathkumar msampathkumar requested review from a team as code owners September 26, 2024 17:23
Copy link

snippet-bot bot commented Sep 26, 2024

Here is the summary of changes.

You are about to delete 24 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@msampathkumar msampathkumar added the snippet-bot:force-run Force snippet-bot runs its logic label Sep 26, 2024
@msampathkumar
Copy link
Member

CICD Error:

File "/workspace/generative_ai/function_calling/chat_function_calling_config.py", line 80, in generate_text
    print("Function:", response.choices[0].message.tool_calls[0].id)
TypeError: 'NoneType' object is not subscriptable

@snippet-bot snippet-bot bot removed the snippet-bot:force-run Force snippet-bot runs its logic label Sep 26, 2024
@msampathkumar msampathkumar removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 30, 2024
Copy link
Member

@msampathkumar msampathkumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved the PR after, manually verified several region tags.

@msampathkumar msampathkumar merged commit 54e355f into main Oct 1, 2024
16 checks passed
@msampathkumar msampathkumar deleted the Cleaning-Samples-Group-A branch October 1, 2024 11:29
riathakkar pushed a commit to riathakkar/python-docs-samples that referenced this pull request Oct 8, 2024
…ation, Embeddings, Extensions, Function Calling) (GoogleCloudPlatform#12635)

* Delete old Samples from Group A

* Delete useless tests

* Specified the location for the model.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants