Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(generativeai): update prompt optimizer sample and tests #12630

Merged
merged 12 commits into from
Sep 24, 2024

Conversation

Sita04
Copy link
Collaborator

@Sita04 Sita04 commented Sep 24, 2024

Update samples and tests for Prompt Optimizer. The static resources have been moved to GCS buckets and the tests can now be made simpler.

@Sita04 Sita04 requested review from a team as code owners September 24, 2024 21:41
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Sep 24, 2024
@Sita04 Sita04 marked this pull request as draft September 24, 2024 21:41
Copy link
Member

@msampathkumar msampathkumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The fix address the reported bucket issues @ #12625 (comment)

Please merge it, after successful completion of CICD tests.

@msampathkumar msampathkumar marked this pull request as ready for review September 24, 2024 21:57
Co-authored-by: Sampath Kumar <sampathm@google.com>
@Sita04 Sita04 added the automerge Merge the pull request once unit tests and other checks pass. label Sep 24, 2024
@gcf-merge-on-green gcf-merge-on-green bot merged commit 8a8e259 into main Sep 24, 2024
14 of 15 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Sep 24, 2024
@gcf-merge-on-green gcf-merge-on-green bot deleted the update-prompt-optmizer-samples branch September 24, 2024 23:42
msampathkumar pushed a commit that referenced this pull request Sep 24, 2024
Update samples and tests for Prompt Optimizer. The static resources have been moved to GCS buckets and the tests can now be made simpler.
riathakkar pushed a commit to riathakkar/python-docs-samples that referenced this pull request Oct 8, 2024
…oudPlatform#12630)

Update samples and tests for Prompt Optimizer. The static resources have been moved to GCS buckets and the tests can now be made simpler.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants