Skip to content

Conversation

@Thoughtseize1
Copy link
Contributor

@Thoughtseize1 Thoughtseize1 commented Sep 16, 2024

Description

Created new folder

Region_tag New file
generativeaionvertexai_gemini_grounding_with_web grounding/web_example.py
generativeaionvertexai_gemini_grounding_with_vais grounding/vais_example.py
generativeaionvertexai_grounding grounding/palm_example.py

❗Files need to be deleted after approval in /generative_ai folder:

  • grounding.py
  • grounding_test.py
  • gemini_grounding_example.py
  • Marked tests in test_gemini_examples.py

I was unable to successfully test the following Samples. PTAL at doc

Checklist

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Sep 16, 2024
@Thoughtseize1 Thoughtseize1 added kokoro:force-run Add this label to force Kokoro to re-run the tests. snippet-bot:force-run Force snippet-bot runs its logic labels Sep 16, 2024
@snippet-bot snippet-bot bot removed the snippet-bot:force-run Force snippet-bot runs its logic label Sep 16, 2024
@snippet-bot
Copy link

snippet-bot bot commented Sep 16, 2024

Here is the summary of changes.

You are about to add 3 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 16, 2024
@Thoughtseize1 Thoughtseize1 marked this pull request as ready for review September 16, 2024 15:38
@Thoughtseize1 Thoughtseize1 requested review from a team as code owners September 16, 2024 15:38
@Thoughtseize1
Copy link
Contributor Author

I encountered several issues while testing these samples. In general:
google.api_core.exceptions.InternalServerError: 500 Internal error encountered.

Please refer to the document where I have outlined the problems and possible improvements in the documentation.

@msampathkumar msampathkumar added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 26, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 26, 2024
@msampathkumar
Copy link
Member

Update: google.api_core.exceptions.InternalServerError: 500 Internal error encountered. - As the CICD tests run in parallel, this error seem occur. Manually re-starting the CICD.

@msampathkumar msampathkumar added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 1, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 1, 2024
@msampathkumar msampathkumar dismissed holtskinner’s stale review October 1, 2024 13:27

Hi Holt, this request is open for 2 weeks. So I am reviewing and closing if off.

@msampathkumar msampathkumar merged commit f6afe04 into main Oct 1, 2024
15 checks passed
@msampathkumar msampathkumar deleted the Reorganize-GenAI-Samples-Grounding branch October 1, 2024 13:27
riathakkar pushed a commit to riathakkar/python-docs-samples that referenced this pull request Oct 8, 2024
…dPlatform#12594)

* New files for "Grounding" folder

* Added marks for files to delete

* Fix lint

* Fix filename

* Update generative_ai/grounding/test_grounding.py

* Update generative_ai/grounding/test_grounding.py

---------

Co-authored-by: Holt Skinner <13262395+holtskinner@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants