Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notebook to quickly generate and load embeddings in AlloyDB. #12588

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

paulramsey
Copy link

Add AlloyDB Embeddings Notebook

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

@paulramsey paulramsey requested review from a team as code owners September 12, 2024 15:59
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: notebooks Issues related to the Vertex AI Workbench API. labels Sep 12, 2024
Copy link
Contributor

@kurtisvg kurtisvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some quick issues I see while reviewing:

P0s:

  • The code is not tested (which is required to merge)
  • Versions installed w/ pip should be pinned to prevent issues with updates
  • We should update to load data from a file -- either a file in this repo or a public GCS bucket to streamline implementation

P1s:

  • We should be using type hints
  • User inputs should be streamlined to not rely on Secret Manager -- something like the "Set up alloyDB" section here would be preferred
  • We should evaluate using asyncio -- much of this is blocked on I/O, may speed it up considerably to operate in parallel
  • Need to evaluate failure for vertex AI quota issues

P2s:

  • Should consider using a generator for a batching function (python best practice)
  • We may also want to consider using the AlloyDB Python Connector here for mTLS + make execution in the codelab better

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: notebooks Issues related to the Vertex AI Workbench API. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants