Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update Django samples to 5.1 (Python 3.10+) #12122

Merged
merged 7 commits into from
Aug 9, 2024
Merged

chore: update Django samples to 5.1 (Python 3.10+) #12122

merged 7 commits into from
Aug 9, 2024

Conversation

glasnt
Copy link
Contributor

@glasnt glasnt commented Aug 9, 2024 •
edited
Loading

Description

Replaces #12111, #12112, #12113, #12114, #12116, #12117

  • Updates Django 5.x series to 5.1 for Python 3.10+
  • Updates Django 4.x series to latest patch for Python 3.8+
  • Updates Django 3.x series to latest patch for <Python 3.8
  • Removes duplicate dependency declaration for Python 3.10 in some samples
  • Applies django-upgrade targetting minimum supported version per sample (s/re_path/path, adds STORAGES)
  • Please merge this PR for me once it is approved

@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: appengine Issues related to the App Engine Admin API API. api: container Issues related to the Kubernetes Engine API API. api: run Issues related to the Cloud Run API. labels Aug 9, 2024
@glasnt glasnt marked this pull request as ready for review August 9, 2024 09:01
@glasnt glasnt requested review from a team as code owners August 9, 2024 09:01
iennae
iennae approved these changes Aug 9, 2024
View reviewed changes
Copy link
Contributor

@iennae iennae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @glasnt for helping keep our samples fresh!

@iennae iennae merged commit 3b1d83f into main Aug 9, 2024
14 checks passed
@iennae iennae deleted the django51 branch August 9, 2024 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iennae iennae iennae approved these changes

Assignees

@donmccasland donmccasland

Labels
api: appengine Issues related to the App Engine Admin API API. api: container Issues related to the Kubernetes Engine API API. api: run Issues related to the Cloud Run API. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@glasnt @iennae @donmccasland