-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable_word_time_offsets=False to a few examples, and added enable_wor… #1046
enable_word_time_offsets=False to a few examples, and added enable_wor… #1046
Conversation
…d_time_offsets=True to local file verison of transcribe_async
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
I am covered by employment agreement |
@dlaqab you need to register your github username at go/github, and make sure your @google.com address is associated with your github profile. |
@@ -46,7 +46,8 @@ def run_quickstart(): | |||
config = types.RecognitionConfig( | |||
encoding=enums.RecognitionConfig.AudioEncoding.LINEAR16, | |||
sample_rate_hertz=16000, | |||
language_code='en-US') | |||
language_code='en-US', | |||
enable_word_time_offsets=False) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this defaults to false, then we should just leave it out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreeing with @jonparrott on this: This is definitely something we want to make clear in the API/client library reference, but adding this in the sample codes would make the API seem harder to use than it actually is (note that the other parameters encoding
, langauge_code
, and sample_rate_hertz
are all required, but enable_word_time_offsets
is optional and defaults to false).
What are some possible use case scenarios where not showing enable_word_time_offsets=False
could cause friction for the users?
@jonparrott thanks for the pointer - Done |
CLAs look good, thanks! |
The enable_word_time_offsets=False parameter in these samples is extraneous to the task these samples are intended to demonstrate. Closing. |
Note: samples which demonstrate Enable Word Time Offsets were added to python-docs-samples in #1050 |
Added enable_word_time_offsets=True to local file version of transcribe_async
Added enable_word_time_offsets=False to other recognize samples (except streaming)