-
Notifications
You must be signed in to change notification settings - Fork 6.6k
fix: composer e2e test failure #10122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we really want to ignore all Internal Server Errors? Looking at the linked issue this happens everyday for last couple weeks, so I think we should report to the product team and find the root cause instead of hiding the failure.
Good point. I have filed an internal bug to address the root cause. Also notice that the try / except cause is very tightly scoped to the |
Hi - coming back from OOO today and catching up. Agreed with Remi that ignoring all internal service error seems like a bad plan. I commented on the internal linked issue - this actually is an error from the Dataproc service not from Composer. I'd like to mark this as Do Not Merge until we reach consensus on internal bug 285632121 |
Add error response type when deleting a batch at end of test.
An internal bug can also be filed to address root cause.
Fixes #9945