Skip to content

Conversation

kweinmeister
Copy link
Contributor

Add error response type when deleting a batch at end of test.

An internal bug can also be filed to address root cause.

Fixes #9945

@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: composer Issues related to the Cloud Composer API. labels May 29, 2023
@kweinmeister kweinmeister added the snippet-bot:force-run Force snippet-bot runs its logic label May 29, 2023
@snippet-bot snippet-bot bot removed the snippet-bot:force-run Force snippet-bot runs its logic label May 29, 2023
@kweinmeister kweinmeister marked this pull request as ready for review May 29, 2023 16:26
@kweinmeister kweinmeister requested review from a team as code owners May 29, 2023 16:26
Copy link
Member

@rsamborski rsamborski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really want to ignore all Internal Server Errors? Looking at the linked issue this happens everyday for last couple weeks, so I think we should report to the product team and find the root cause instead of hiding the failure.

@kweinmeister
Copy link
Contributor Author

Do we really want to ignore all Internal Server Errors? Looking at the linked issue this happens everyday for last couple weeks, so I think we should report to the product team and find the root cause instead of hiding the failure.

Good point. I have filed an internal bug to address the root cause. Also notice that the try / except cause is very tightly scoped to the delete_batch() API call throwing this error, which is at the very end of a teardown step.

@leahecole
Copy link
Collaborator

Hi - coming back from OOO today and catching up. Agreed with Remi that ignoring all internal service error seems like a bad plan. I commented on the internal linked issue - this actually is an error from the Dataproc service not from Composer. I'd like to mark this as Do Not Merge until we reach consensus on internal bug 285632121

@leahecole leahecole added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jun 5, 2023
@leahecole leahecole removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jun 8, 2023
@kweinmeister kweinmeister merged commit b17fa1d into main Jun 8, 2023
@kweinmeister kweinmeister deleted the issue-9945 branch June 8, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: composer Issues related to the Cloud Composer API. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

composer.2022_airflow_summit.data_analytics_process_expansion_test: test_process failed
6 participants