Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing test: DLP: test_inspect_bigquery #9164

Closed
Sita04 opened this issue Feb 22, 2023 · 5 comments
Closed

Failing test: DLP: test_inspect_bigquery #9164

Sita04 opened this issue Feb 22, 2023 · 5 comments
Assignees
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. samples Issues that are directly related to samples. triage me I really want to be triaged. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@Sita04
Copy link
Collaborator

Sita04 commented Feb 22, 2023

Test fails with error "Table not found". Needs inspection.
Skipped in migration PR: b433f64

@Sita04 Sita04 added triage me I really want to be triaged. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Feb 22, 2023
@Sita04 Sita04 self-assigned this Feb 22, 2023
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Feb 22, 2023
@leahecole
Copy link
Collaborator

@kweinmeister I wonder if this has to do with reaper?

@kweinmeister
Copy link
Contributor

@leahecole Just saw this now :)

Here's what I see: dlp_test_project is in the list of opt-out regexes for Reaper (so it does get deleted). However, this test creates a new table here:

@pytest.fixture(scope="module")
def bigquery_project():
...
table = bigquery_client.create_table(table)

@Sita04 Sita04 assigned annadata and Sita04 and unassigned Sita04 Jul 18, 2023
@msampathkumar
Copy link
Member

msampathkumar commented Aug 23, 2023

Hi @Sita04, can we close this request?

@rsamborski
Copy link
Member

@annadata Can your team PTAL at this one?

@Avani-Thakker
Copy link

Hi, the issue mentioned here seems to use some old code. Ideally, this shouldn't have caused an issue since we had mocked this particular test case as part of PR #10455 . Please check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. samples Issues that are directly related to samples. triage me I really want to be triaged. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

No branches or pull requests

7 participants