Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App Engine testrunner doesn't behave like docs suggest #500

Closed
maltem-za opened this issue Sep 6, 2016 · 1 comment
Closed

App Engine testrunner doesn't behave like docs suggest #500

maltem-za opened this issue Sep 6, 2016 · 1 comment
Assignees
Labels
🚨 This issue needs some love. triage me I really want to be triaged.

Comments

@maltem-za
Copy link

This is relatively minor - just something I noticed relating to /appengine/standard/localtesting/runner.py

The App Engine Setting up a testing framework documentation states: "Test files follow the convention of having test prefixed to their name."

However, 1fe6ae4 changed the behaviour to look for files ending with _test.py

This makes sense if you're trying to run the sample tests, but not if you've used the testrunner on another project and named your test modules according to what has up until now been the default expectation, being test files with test prefixed. If you were to update your testrunner code to the latest and greatest you'll now find none of your tests being run. That is if you notice - assuming most people don't set up their builds to fail on:

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK

So, I would argue that it would be better to stick with the default (discover test files prefixed with test) and instead rename the sample tests.

TL;DR;
minor mismatch with documentation, has potential to cause havoc for people that have used the testrunner and who update it

@theacodes
Copy link
Contributor

This is a great bug report. Thank you, I'll investigate shortly.

@theacodes theacodes self-assigned this Sep 6, 2016
@theacodes theacodes added the bug label Sep 6, 2016
@yoshi-automation yoshi-automation added triage me I really want to be triaged. 🚨 This issue needs some love. labels Apr 7, 2020
engelke pushed a commit that referenced this issue Nov 28, 2022
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
dandhlee pushed a commit that referenced this issue Nov 29, 2022
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚨 This issue needs some love. triage me I really want to be triaged.
Projects
None yet
Development

No branches or pull requests

3 participants