Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests] Firestore: add asserts into snippets tests #4362

Open
IlyaFaer opened this issue Jul 23, 2020 · 1 comment
Open

[tests] Firestore: add asserts into snippets tests #4362

IlyaFaer opened this issue Jul 23, 2020 · 1 comment
Assignees
@triplequark
Labels
api: firestore Issues related to the Firestore API. samples Issues that are directly related to samples. testing type: cleanup An internal cleanup or hygiene concern.

Comments

@IlyaFaer
Copy link

It was noticed that most of the snippet tests in Firestore doesn't do any asserts.
As per comments it should be fixed.

/cc @tmatsuo, @busunkim96
@IlyaFaer IlyaFaer self-assigned this Jul 23, 2020
@IlyaFaer IlyaFaer added api: firestore Issues related to the Firestore API. testing labels Jul 23, 2020
@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label Jul 23, 2020
@busunkim96 busunkim96 added type: cleanup An internal cleanup or hygiene concern. and removed triage me I really want to be triaged. labels Jul 23, 2020
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Aug 21, 2020
@IlyaFaer IlyaFaer mentioned this issue Sep 28, 2020
Closed
@busunkim96 busunkim96 removed their assignment Dec 8, 2020
@dandhlee
Copy link
Collaborator

Friendly ping @IlyaFaer, could you work on adding this soon? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@triplequark triplequark

Labels
api: firestore Issues related to the Firestore API. samples Issues that are directly related to samples. testing type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@busunkim96 @IlyaFaer @yoshi-automation @dandhlee @triplequark