jobs.v3.api_client.auto_complete_sample_test: test_auto_complete_sample failed #2945
Assignees
Labels
api: talent
priority: p2
Moderately-important priority. Fix may not be included in next release.
type: bug
Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Comments
flaky-bot
bot
added
buildcop: issue
priority: p1
|
Closing as a duplicate of #2944 |
1 similar comment
|
Closing as a duplicate of #2944 |
|
Looks like this issue is flaky. 😟 I'm going to leave this open and stop commenting. A human should fix and close this. jobs.v3.api_client.auto_complete_sample_test: test_auto_complete_sample failed |
crwilcox
added
priority: p2
|
I was able to run the tests. They all passed. I think I'll need to scrutiny the test code to find why it's flaky. |
|
Ouch. In the sample code, I found the following: # Wait several seconds for post processing
time.sleep(10) |
tmatsuo
pushed a commit
to tmatsuo/python-docs-samples
that referenced
this issue
Apr 3, 2020
fixes GoogleCloudPlatform#2945 fixes GoogleCloudPlatform#2818 There were 8 tests which has `time.sleep(10)` for waiting data propagation or whatever. I chose to use `@eventually_consistent.call` instead of sleep in those tests. Bonus point is now the tests are significantly faster because it doesn't always wait for 10 seconds. The downside is it will take a long time on failure. We may want to specify the retry count on the eventualy consistent decorator once the following issue is fixed: GoogleCloudPlatform/python-repo-tools#25
tmatsuo
pushed a commit
to tmatsuo/python-docs-samples
that referenced
this issue
Apr 3, 2020
fixes GoogleCloudPlatform#2945 fixes GoogleCloudPlatform#2818 There were 8 tests which has `time.sleep(10)` for waiting data propagation or whatever. I chose to use `@eventually_consistent.call` instead of sleep in those tests. Bonus point is now the tests are significantly faster because it doesn't always wait for 10 seconds. The downside is it will take a long time on failure. We may want to specify the retry count on the eventualy consistent decorator once the following issue is fixed: GoogleCloudPlatform/python-repo-tools#25
tmatsuo
pushed a commit
to tmatsuo/python-docs-samples
that referenced
this issue
Apr 3, 2020
fixes GoogleCloudPlatform#2945 fixes GoogleCloudPlatform#2818 There were 8 tests which has `time.sleep(10)` for waiting data propagation or whatever. I chose to use `@eventually_consistent.call` instead of sleep in those tests. Bonus point is now the tests are significantly faster because it doesn't always wait for 10 seconds. The downside is it will take a long time on failure. We may want to specify the retry count on the eventualy consistent decorator once the following issue is fixed: GoogleCloudPlatform/python-repo-tools#25
tmatsuo
pushed a commit
that referenced
this issue
Apr 7, 2020
* [jobs] testing: reduce test flakiness fixes #2945 fixes #2818 There were 8 tests which has `time.sleep(10)` for waiting data propagation or whatever. I chose to use `@eventually_consistent.call` instead of sleep in those tests. Bonus point is now the tests are significantly faster because it doesn't always wait for 10 seconds. The downside is it will take a long time on failure. We may want to specify the retry count on the eventualy consistent decorator once the following issue is fixed: GoogleCloudPlatform/python-repo-tools#25 * style fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
jobs.v3.api_client.auto_complete_sample_test: test_auto_complete_sample failed
buildID: 0715f7d
buildURL: Build Status, Sponge
status: failed
The text was updated successfully, but these errors were encountered: