Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pub/Sub: reformat code to follow style guide #2599

Closed
anguillanneuf opened this issue Dec 11, 2019 · 3 comments
Closed

Pub/Sub: reformat code to follow style guide #2599

anguillanneuf opened this issue Dec 11, 2019 · 3 comments
Assignees
Labels
api: pubsub Issues related to the Pub/Sub API. type: cleanup An internal cleanup or hygiene concern.

Comments

@anguillanneuf
Copy link
Member

anguillanneuf commented Dec 11, 2019

In a recent #2555, black introduced format changes that don't conform to Google's style guide.

  • Use single quotes instead of double quotes
  • etc.

Please update the code in the Pub/Sub subdirectory so they are standardized across the entire repo.

@anguillanneuf anguillanneuf self-assigned this Dec 11, 2019
@anguillanneuf anguillanneuf added api: pubsub Issues related to the Pub/Sub API. type: cleanup An internal cleanup or hygiene concern. labels Dec 11, 2019
@andrewferlitsch
Copy link
Contributor

@anguillanneuf PTAL

@anguillanneuf
Copy link
Member Author

anguillanneuf commented Mar 17, 2020

@andrewferlitsch I haven't looked it this issue for some while.

Do you know what's the magic formatting command(s) that let all samples 1) pass all lint tests 2) conform to all formatting style guide?

@leahecole
Copy link
Collaborator

I'm going to close this for now because right now, black is the best thing we have for auto-formatting, and pub/sub passes lint regularly, so I am not too worried. However, if you do notice that lint rules look off in the noxfile-template, please let me know. I know @gguuss had a lot of opinions about the style when #2555 first came around, but given that we have not come up with a better solution between the time this issue was opened and now, I don't think it's worth leaving this open. Happy to be contradicted with good reason though, Tianzi! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the Pub/Sub API. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Development

No branches or pull requests

3 participants