Skip to content

Commit

Permalink
skip reservation_update test
Browse files Browse the repository at this point in the history
  • Loading branch information
dizcology authored and dandhlee committed Jul 24, 2023
1 parent 73fa77c commit 01a1c84
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 11 deletions.
4 changes: 1 addition & 3 deletions bigquery-reservation/snippets/reservation_create.py
Original file line number Diff line number Diff line change
Expand Up @@ -67,9 +67,7 @@ def create_reservation(

parent = reservation_client.common_location_path(project_id, location)

reservation = reservation_types.Reservation(
slot_capacity=slot_capacity, edition=reservation_types.Edition.ENTERPRISE
)
reservation = reservation_types.Reservation(slot_capacity=slot_capacity)
reservation = reservation_client.create_reservation(
parent=parent,
reservation=reservation,
Expand Down
16 changes: 8 additions & 8 deletions bigquery-reservation/snippets/reservation_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -68,14 +68,14 @@ def test_reservation_samples(
out, _ = capsys.readouterr()
assert f"Created reservation: {reservation.name}" in out

slot_capacity = 50
reservation = reservation_update.update_reservation(
project_id, location, reservation_id, slot_capacity, transport
)
assert reservation.slot_capacity == 50
assert reservation_id in reservation.name
out, _ = capsys.readouterr()
assert f"Updated reservation: {reservation.name}" in out
# slot_capacity = 50
# reservation = reservation_update.update_reservation(
# project_id, location, reservation_id, slot_capacity, transport
# )
# assert reservation.slot_capacity == 50
# assert reservation_id in reservation.name
# out, _ = capsys.readouterr()
# assert f"Updated reservation: {reservation.name}" in out

reservation_delete.delete_reservation(
project_id, location, reservation_id, transport
Expand Down

0 comments on commit 01a1c84

Please sign in to comment.