fix release-2.45.3-gmp vulnerabilities; remove vendor #271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: bwplotka <bwplotka@gmail.com>
Signed-off-by: bwplotka <bwplotka@gmail.com>
bwplotka
changed the title
bwplotka
force-pushed
the
bwplotka/release-2.45.3-gmp-gmpctl-vulnfix
branch
2 times, most recently
from
b03a3b4 to
7dda7cc
Compare
…pt from 2.53.5 Signed-off-by: bwplotka <bwplotka@gmail.com>
Signed-off-by: bwplotka <bwplotka@gmail.com>
bwplotka
force-pushed
the
bwplotka/release-2.45.3-gmp-gmpctl-vulnfix
branch
from
7dda7cc to
d364277
Compare
pintohutch
reviewed
Dec 16, 2025
| @@ -1,29 +1,72 @@ | |||
| ARG IMAGE_BUILD_NODEJS=launcher.gcr.io/google/nodejs | |||
Collaborator
There was a problem hiding this comment.
Could we get away with just:
ARG IMAGE_BUILD_NODEJS=node:17.9.0-buster?
and removing the install_node command on line 12?
And leave everything else alone except for the go bump to address the vulnz?
Collaborator
Author
There was a problem hiding this comment.
I can try, but I thought it will be easier and more consistent to 2.53.5 way of thins.
Collaborator
Author
There was a problem hiding this comment.
Trying on another PR: #272
error so far https://github.com/GoogleCloudPlatform/prometheus/actions/runs/20275550076/job/58223081923?pr=272
Collaborator
Author
|
Simpler fix: #272 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes vulnerabilities.
Unfortunately, on the way our old way of building UI also started to fail (new image upgraded node?): https://github.com/GoogleCloudPlatform/prometheus/actions/runs/20249220559/job/58137089941
As a result, it will be simpler to port 2.53.5 Prometheus fork artifacts.