Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Anthos on VMware Ansible module - Fix AdminWS upgrade issue and update README.md #924

Merged
merged 5 commits into from
Nov 2, 2022
Merged

Anthos on VMware Ansible module - Fix AdminWS upgrade issue and update README.md #924

merged 5 commits into from
Nov 2, 2022

Conversation

ravi-nal
Copy link
Contributor

Pull Request Template

Please, go through these steps before you submit a PR.

  1. Make sure that your PR is not a duplicate.

  2. Before submitting the PR, review your changes:

    • Adjust the code to the existing style.
    • Add a set of unit tests for the changes and ensure they all pass.
    • Add accompanying README.md file with instructions on usage. See awesome-readme for good examples of high-quality READMEs.
    • Add a link to your contribution in the top-level README (alpha-order).
    • Add Apache 2.0 license headers with an up-to-date copyright date attributed to Google LLC.
    • Remove unnecessary LICENSE files. There's no need to include an additional license since all repository submissions are covered by the top-level Apache 2.0 license.

  3. After these steps, you're ready to open a pull request.

    • Give a descriptive title to your PR.
    • Provide a description of your changes.
    • Put closes #XXXX in your comment to auto-close the issue that your PR fixes (if such).

PLEASE REMOVE THIS TEMPLATE BEFORE SUBMITTING

@pull-request-size pull-request-size bot added the size/XXL Denotes a PR that changes 1000+ lines. label Oct 31, 2022
@agold-rh agold-rh merged commit 65081e2 into GoogleCloudPlatform:main Nov 2, 2022
SMaktub pushed a commit to SMaktub/professional-services that referenced this pull request Dec 13, 2022
@ravi-nal @agold-rh @SMaktub
Anthos on VMware Ansible module - Fix AdminWS upgrade issue and updat…
b923e47 
…e README.md (GoogleCloudPlatform#924)

* Anthos VMware Ansible module

* Fix AdminWS upgrade issue, update README.md with example summary

Co-authored-by: Andrew Gold <41129777+agold-rh@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agold-rh agold-rh agold-rh approved these changes

Assignees
No one assigned
Labels
size/XXL Denotes a PR that changes 1000+ lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ravi-nal @agold-rh