Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inherit Coder from coders. #879

Merged
merged 1 commit into from
Aug 29, 2022
Merged

Conversation

robertwb
Copy link
Contributor

It'd really be better to not use a Coder here at all, but this at least fixes the breakage.

Please, go through these steps before you submit a PR.

  1. Make sure that your PR is not a duplicate.

  2. Before submitting the PR, review your changes:

    • Adjust the code to the existing style.
    • Add a set of unit tests for the changes and ensure they all pass.
    • Add accompanying README.md file with instructions on usage. See awesome-readme for good examples of high-quality READMEs.
    • Add a link to your contribution in the top-level README (alpha-order).
    • Add Apache 2.0 license headers with an up-to-date copyright date attributed to Google LLC.
    • Remove unnecessary LICENSE files. There's no need to include an additional license since all repository submissions are covered by the top-level Apache 2.0 license.
  3. After these steps, you're ready to open a pull request.

    • Give a descriptive title to your PR.
    • Provide a description of your changes.
    • Put closes #XXXX in your comment to auto-close the issue that your PR fixes (if such).

PLEASE REMOVE THIS TEMPLATE BEFORE SUBMITTING

It'd really be better to not use a Coder here at all, but this at least fixes the breakage.
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines. label Aug 29, 2022
Copy link
Member

@iht iht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iht iht merged commit 7946893 into GoogleCloudPlatform:main Aug 29, 2022
@iht
Copy link
Member

iht commented Aug 29, 2022

Thanks for this contribution to the repo!

SMaktub pushed a commit to SMaktub/professional-services that referenced this pull request Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants