fix(sts-job-manager): Logging Configuration #860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not all operations will have `objectConditions` - namely, if a job has been created outside of the STS Job Manager previously
ludoo
approved these changes
Oct 4, 2022
|
Thanks @ludoo! Feel free to merge when ready. |
SMaktub
pushed a commit
to SMaktub/professional-services
that referenced
this pull request
Dec 13, 2022
* fix(sts-job-manager): Fix accessing `objectConditions` Not all operations will have `objectConditions` - namely, if a job has been created outside of the STS Job Manager previously * fix: logging configuration Co-authored-by: Ludovico Magnocavallo <ludomagno@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today, some logs (called via
logger) were not outputting due to missing configuration setup.Additionally,
logging(the general logger) was used rather thanlogger.This PR cleans up the logging functionality for STS Job Manager.