Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix: QMS Alerting #855

Merged

Conversation

anuradha-bajpai-google
Copy link
Contributor

QMS alerting stopped working due to mismatch in version between code and TF. TF has been fixed and alerting is working now.

@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines. label Jul 7, 2022
@anuradha-bajpai-google
Copy link
Contributor Author

Please review and merge. This is bug fix for a blocker.

@anuradha-bajpai-google
Copy link
Contributor Author

Please review the code. This is impacting many customers.

Copy link
Member

@aymanfarhat aymanfarhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for the fix

@aymanfarhat aymanfarhat merged commit bb4efaf into GoogleCloudPlatform:main Oct 27, 2022
SMaktub pushed a commit to SMaktub/professional-services that referenced this pull request Dec 13, 2022
* Fixed bug: QMS alerting TF code

* Alerting bug fix

Co-authored-by: Ayman Farhat <823713+aymanfarhat@users.noreply.github.com>
@anuradha-bajpai-google anuradha-bajpai-google deleted the hotfix/qms-alert branch May 22, 2023 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants