Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated Pubsub2Inbox to version 1.2.0 #698

Merged
merged 1 commit into from
Oct 7, 2021
Merged

Updated Pubsub2Inbox to version 1.2.0 #698

merged 1 commit into from
Oct 7, 2021

Conversation

rosmo
Copy link
Collaborator

@rosmo rosmo commented Sep 30, 2021

Added:

  • New projects processor for fetching project details from CRM.
  • BigQuery output for writing data to BigQuery datasets.
  • New recommenders/insights types and quota project support to recommender processor.
  • contains -filter in Jinja
  • New live GCP environment tests.

Changed:

  • Updated dependencies to latest plus refactored code.
  • Improved Terraform code.
  • "All mail transports failed" is now an error.

@pull-request-size pull-request-size bot added the size/XXL Denotes a PR that changes 1000+ lines. label Sep 30, 2021
@google-cla google-cla bot added the cla: yes All committers have signed a CLA label Sep 30, 2021
@rosmo rosmo force-pushed the pubsub2inbox-updates branch 2 times, most recently from 75ab58d to a46f26b Compare September 30, 2021 14:22
@iht
Copy link
Member

iht commented Oct 4, 2021

/gcbrun

iht
iht approved these changes Oct 4, 2021
View reviewed changes
Copy link
Member

@iht iht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a single minor comment.

LGTM

@iht
Copy link
Member

iht commented Oct 4, 2021

Please fix the problems detected by the linter:

Validating ./tools/pubsub2inbox - Checking python files
./processors/projects.py:15:1: F401 'googleapiclient.http' imported but unused
./processors/projects.py:24:19: F821 undefined name 'NotConfiguredException'
./processors/cai.py:15:1: F401 'googleapiclient.http' imported but unused
./processors/monitoring.py:15:1: F401 'google.auth' imported but unused
./processors/monitoring.py:16:1: F401 'google_auth_httplib2' imported but unused
./processors/monitoring.py:17:1: F401 'googleapiclient.http' imported but unused
./processors/groups.py:15:1: F401 'googleapiclient.http' imported but unused
./processors/groups.py:17:1: F401 'google_auth_httplib2' imported but unused
./processors/recommendations.py:22:1: F401 'googleapiclient.http' imported but unused
./output/test.py:15:1: F401 'sys' imported but unused
./output/bigquery.py:15:1: F401 'google.api_core.gapic_v1.client_info as grpc_client_info' imported but unused
./output/bigquery.py:17:1: F401 'helpers.base.PUBSUB2INBOX_VERSION' imported but unused
./output/base.py:16:1: F401 'google.cloud.iam_credentials_v1.IAMCredentialsClient' imported but unused
./output/gcscopy.py:16:1: F401 'helpers.base.PUBSUB2INBOX_VERSION' imported but unused
./helpers/base.py:129:51: F821 undefined name 'var'
./test/test_ingcp.py:18:1: F401 'time' imported but unused

@iht iht self-requested a review October 4, 2021 13:44
@rosmo rosmo force-pushed the pubsub2inbox-updates branch 3 times, most recently from 922b0c3 to fc2a608 Compare October 7, 2021 09:19
@rosmo
Copy link
Collaborator Author

rosmo commented Oct 7, 2021

I fixed the linter errors, can you gcbrun again?

@iht
Copy link
Member

iht commented Oct 7, 2021

/gcbrun

@rosmo
Updated Pubsub2Inbox to version 1.2.0
6707d43 
Added:
- New projects processor for fetching project details from CRM.
- BigQuery output for writing data to BigQuery datasets.
- New recommenders/insights types and quota project support to recommender processor.
- contains -filter in Jinja
- New live GCP environment tests.
- Processor documentation.

Changed:
- Updated dependencies to latest plus refactored code.
- Improved Terraform code.
- "All mail transports failed" is now an error.
@rosmo rosmo force-pushed the pubsub2inbox-updates branch from 822b9c4 to 6707d43 Compare October 7, 2021 11:01
@iht
Copy link
Member

iht commented Oct 7, 2021

/gcbrun

@iht iht merged commit abdd06b into GoogleCloudPlatform:main Oct 7, 2021
@iht
Copy link
Member

iht commented Oct 7, 2021

Thanks for your contribution!

rosmo added a commit to rosmo/professional-services that referenced this pull request Mar 17, 2022
@rosmo
Updated Pubsub2Inbox to version 1.2.0 (GoogleCloudPlatform#698)
0a84045 
Added:
- New projects processor for fetching project details from CRM.
- BigQuery output for writing data to BigQuery datasets.
- New recommenders/insights types and quota project support to recommender processor.
- contains -filter in Jinja
- New live GCP environment tests.
- Processor documentation.

Changed:
- Updated dependencies to latest plus refactored code.
- Improved Terraform code.
- "All mail transports failed" is now an error.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iht iht Awaiting requested review from iht

Assignees
No one assigned
Labels
cla: yes All committers have signed a CLA size/XXL Denotes a PR that changes 1000+ lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rosmo @iht