Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide optional path for bmctl #693

Merged
merged 4 commits into from
Sep 13, 2021
Merged

Conversation

rajeshml
Copy link
Contributor

Existing playbook installs bmctl in \usr\local\sbin, for troubleshooting or development needs there is a need to have different ABM versions installed on admin workstation at any given time. This PR gives the user the ability to choose a custom path for where bmctl resides for each install.

Unit test logs attached to the Engineering council bug id.

@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines. label Sep 13, 2021
@google-cla google-cla bot added the cla: yes All committers have signed a CLA label Sep 13, 2021
@iht
Copy link
Member

iht commented Sep 13, 2021

/gcbrun

Copy link
Member

@iht iht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iht
Copy link
Member

iht commented Sep 13, 2021

/gcbrun

@iht iht merged commit 78e08bc into GoogleCloudPlatform:main Sep 13, 2021
rosmo pushed a commit to rosmo/professional-services that referenced this pull request Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes All committers have signed a CLA size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make bmctl executable path user configurable
2 participants