-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BQTag Alpha Version #668
BQTag Alpha Version #668
Conversation
/gcbrun |
@iht Hi Israel, I would appreciate if you cold review this PR. |
@iht do you want to take this one ? I can if you don't have time |
/gcbrun |
Taking this one for review. Starting now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please the inline comments for the specific requested changes.
@iht Thank you Israel for reviewing the code and providing the valuable insights. I have made all the changes suggested by you and pushed it the main branch of my forked repo. Please let me know if any other changes are required. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, there are still some Python style bits to be fixed. Perhaps you could try to use some tool such as black to reformat the remaining parts of the code: https://www.freecodecamp.org/news/auto-format-your-python-code-with-black/
@iht Thank you for the suggestion. I have formatted the code using black and pushed it to my repo. I also ran the tests to ensure formatting did not break anything and tests ran fine.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/gcbrun |
First PR for a new tool called as BQTag. Utility class for tagging BQ Table Schemas with Data Catalog Taxonomy Policy Tags. Create BQ Authorised Views using Policy Tags. Helper utility to provision BigQuery Dataset, Data Catalog Taxonomy and Policy Tags.