Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gmon to google-cloud-monitoring v2.x.x and above #623

Merged
merged 2 commits into from
Mar 21, 2021

Conversation

ocervell
Copy link
Contributor

Library stopped working because of the 1.x --> 2.x upgrade of the google-cloud-monitoring library, which breaks things. This bugfix version updates gmon to use the new interface offered in google-cloud-monitoring, and fixes the issues encountered when using the library.

@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines. label Mar 12, 2021
@google-cla google-cla bot added the cla: yes All committers have signed a CLA label Mar 12, 2021
Copy link
Collaborator

@rosmo rosmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, seems there's no functional changes (mostly formatting + new library).

Copy link
Member

@iht iht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as per @rosmo review

@iht iht merged commit a16912f into GoogleCloudPlatform:main Mar 21, 2021
rosmo pushed a commit to rosmo/professional-services that referenced this pull request Mar 17, 2022
…latform#623)

* Update gmon to google-cloud-monitoring v2.x.x and above

* Update setup.py version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes All committers have signed a CLA size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants