gcs-bucket-mover: Fix extra retry caused by unhandled exception #607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In particular, IAM details are not available at all if IAM is not enabled as part of the bucket move operation, which may prevent other features (and in particular the locking file) from working.
The bucket counters are later compared as integers, which now fails with:
An exception occured... '>' not supported between instances of 'str' and 'int'
and the exception triggers the upstream retry loop.
eshen1991
approved these changes
Feb 3, 2021
rosmo
pushed a commit
to rosmo/professional-services
that referenced
this pull request
Mar 17, 2022
…leCloudPlatform#607) gcs-bucket-mover: * Fail when run on buckets that do not exist * Comment bucket parameter availability * Display name of bucket being created * Cast transfer counters to int
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Primary fix:
_print_sts_counterscaused by comparingstrandint. This exception was propagating up the call stack until interception by a@retrydecorator, causing a second STS job to be created after the first STS job completed.Ancillary changes: