Add benchmark code for spanner subquery #587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jaketf @sabhyankar |
jaketf
suggested changes
Dec 15, 2020
Co-authored-by: Jacob Ferriero <jferriero@google.com>
|
@jaketf Thank you so much for the detailed comment! I fixed the code and README accordingly. Could you please review it again? |
jaketf
approved these changes
Dec 16, 2020
rosmo
pushed a commit
to rosmo/professional-services
that referenced
this pull request
Feb 1, 2021
* Add benchmark code for spanner subquery * Update toplevel README * Apply suggestions from code review Co-authored-by: Jacob Ferriero <jferriero@google.com> * Fix README and benchmark pattern * Add how to stop benchmark Co-authored-by: Jacob Ferriero <jferriero@google.com>
rosmo
pushed a commit
to rosmo/professional-services
that referenced
this pull request
Mar 17, 2022
* Add benchmark code for spanner subquery * Update toplevel README * Apply suggestions from code review Co-authored-by: Jacob Ferriero <jferriero@google.com> * Fix README and benchmark pattern * Add how to stop benchmark Co-authored-by: Jacob Ferriero <jferriero@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the Cloud Spanner's benchmark code for my upcoming medium blog (in Japanese). I will update README once the blog post is published.