Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to new billing export schema #560

Merged
merged 3 commits into from
Oct 22, 2020
Merged

Update to new billing export schema #560

merged 3 commits into from
Oct 22, 2020

Conversation

kardiff18
Copy link
Contributor

The billing export schema recently added in 3 new columns - updated the output query to comply with the new schema and fix any UNION ALL errors.

@google-cla google-cla bot added the cla: yes All committers have signed a CLA label Sep 24, 2020
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines. label Sep 24, 2020
jaketf
jaketf approved these changes Oct 1, 2020
View reviewed changes
Copy link

@jaketf jaketf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You will be my best friend if you can set up some CI for the sql.
E.g. can we set up these tables in the eng council project and bq query --dryrun them
This can wait for a later PR.

@jaketf jaketf merged commit 2d77d42 into GoogleCloudPlatform:master Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaketf jaketf jaketf approved these changes

Assignees
No one assigned
Labels
cla: yes All committers have signed a CLA size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kardiff18 @jaketf