Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove GCP arch viz since it's moved to Forseti #484

Merged
merged 4 commits into from
May 18, 2020

Conversation

ryanmcdowell
Copy link
Contributor

The person who maintains GCP arch viz is no longer able to maintain it and the tool has been pulled into Forseti.

https://cloud.google.com/blog/products/identity-security/understand-gcp-organization-resource-hierarchies-with-forseti-visualizer

@googlebot googlebot added the cla: yes All committers have signed a CLA label May 12, 2020
@ryanmcdowell ryanmcdowell requested a review from jaketf May 12, 2020 16:34
@ryanmcdowell ryanmcdowell linked an issue May 12, 2020 that may be closed by this pull request
Copy link

@jaketf jaketf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this also need to be removed from the README at root of the repo?

@@ -1,42 +0,0 @@
# GCP Architecture Visualizer
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO it would be good to leave a README here that points to the tool's new home.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would removing the sub-directory but modifying the root README to point to the following work or do we always want to keep the sub-directory?

https://github.com/forseti-security/forseti-visualizer

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that makes sense just put link in root readme.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines. label May 16, 2020
@jaketf jaketf merged commit 73b089d into GoogleCloudPlatform:master May 18, 2020
onetwopunch pushed a commit to onetwopunch/professional-services that referenced this pull request Jun 3, 2020
)

* Remove GCP arch viz since it's moved to Forseti

* Revert "Remove GCP arch viz since it's moved to Forseti"

This reverts commit 3c4c85d.

* Remove arch viz and update root README
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes All committers have signed a CLA size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GCP Architecture Visualizer example not working
3 participants