Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Condition on value not index when checking for lastModifiedTime. #454

Merged
merged 2 commits into from
Apr 28, 2020
Merged

Condition on value not index when checking for lastModifiedTime. #454

merged 2 commits into from
Apr 28, 2020

Conversation

bmenasha
Copy link
Contributor

When lastModifiedTime is the first field in the list, the 'if' on it's index
would fail as a zero value is false. Use field value instead.

Pull Request Template

Please, go through these steps before you submit a PR.

  1. Make sure that your PR is not a duplicate.

  2. Before submitting the PR, review your changes:

    • Adjust the code to the existing style.
    • Add a set of unit tests for the changes and ensure they all pass.
    • Add accompanying README.md file with instructions on usage. See awesome-readme for good examples of high-quality READMEs.
    • Add a link to your contribution in the top-level README (alpha-order).
    • Add Apache 2.0 license headers with an up-to-date copyright date attributed to Google LLC.
    • Remove unnecessary LICENSE files. There's no need to include an additional license since all repository submissions are covered by the top-level Apache 2.0 license.
    • For new tools/examples, file your project with the PSO Engineering Council.

  3. After these steps, you're ready to open a pull request.

    • Give a descriptive title to your PR.
    • Provide a description of your changes.
    • Include the Engineering Council bug ID with your pull request.
    • Put closes #XXXX in your comment to auto-close the issue that your PR fixes (if such).

PLEASE REMOVE THIS TEMPLATE BEFORE SUBMITTING

@bmenasha
Condition on value not index when checking for lastModifiedTime.
15f12c9 
When lastModifiedTime is the first field in the list, the 'if' on it's index
would fail as a zero value is false. Use field value instead.
@googlebot googlebot added the cla: yes All committers have signed a CLA label Apr 26, 2020
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines. label Apr 26, 2020
jaketf
jaketf approved these changes Apr 27, 2020
View reviewed changes
Copy link

@jaketf jaketf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaketf jaketf merged commit 58034a6 into GoogleCloudPlatform:master Apr 28, 2020
onetwopunch pushed a commit to onetwopunch/professional-services that referenced this pull request Jun 3, 2020
@bmenasha @onetwopunch
Condition on value not index when checking for lastModifiedTime. (Goo…
3d0e28c 
…gleCloudPlatform#454)

When lastModifiedTime is the first field in the list, the 'if' on it's index
would fail as a zero value is false. Use field value instead.

Co-authored-by: Jacob Ferriero <jferriero@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaketf jaketf jaketf approved these changes

Assignees
No one assigned
Labels
cla: yes All committers have signed a CLA size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bmenasha @jaketf @googlebot