-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds quota manager, which helps in updating the project quotas #432
Conversation
This is awesome! Have you ever tried updating a compute engine quota? I tried this morning and I am getting this error:
I created a new class that passes the "dimension" attribute, and I tried updating a regional quota like nvidia_t4_gpus. I got the idea for the dimension attribute from this page: https://cloud.google.com/service-usage/docs/reference/rest/v1beta1/services.consumerQuotaMetrics.limits.adminOverrides#QuotaOverride |
…mmatically via apis fixes the multiline strings adds yapf formatting adds dimension option yapify
@dvmorris I have added the dimensions but still getting the same error as you have. I suspect that compute engine apis cannot be updated via APIs. I have asked about this internally. You are in CC. |
@dvmorris it turns out that compute engine quotas cannot be updated via APIs yet. But soon they will be ready for update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except one comment
I'm not able to merge this change but it looks good. Added Ryan and Jacob who i believe can merge |
Provides a simple module quota.py to update the service quotas of projects programmatically via APIs.
The other option to update the quotas are via console which is a manual work. So this module enables GCP customer to automate the quota update process.