Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ReadMe.md #400

Merged
merged 3 commits into from
Apr 12, 2020
Merged

Update ReadMe.md #400

merged 3 commits into from
Apr 12, 2020

Conversation

adelanre
Copy link
Contributor

@adelanre adelanre commented Feb 2, 2020

  • Added Destination to log sink create.
  • Add missing \ to the gcloud function deploy.
  • Add LOG_EXPORT_NAME var

- Added Destination to log sink create.
- Add missing `\` to the gcloud function deploy.
- Add LOG_EXPORT_NAME var
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines. label Feb 2, 2020
@googlebot googlebot added the cla: no All committers have NOT signed a CLA label Feb 2, 2020
@adelanre
Copy link
Contributor Author

adelanre commented Feb 2, 2020

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes All committers have signed a CLA and removed cla: no All committers have NOT signed a CLA labels Feb 2, 2020
Copy link
Contributor

@tims tims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stale
Copy link

stale bot commented Mar 19, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale PRs which are > 45 days without activity label Mar 19, 2020
@adelanre adelanre closed this Mar 21, 2020
@adelanre adelanre reopened this Mar 21, 2020
@stale stale bot removed the stale PRs which are > 45 days without activity label Mar 21, 2020
@ryanmcdowell ryanmcdowell merged commit f22cd3a into GoogleCloudPlatform:master Apr 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes All committers have signed a CLA size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants