Fix issue with incorrect image filename generated in annotations #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed handling for home dir shortcut.
EricBeach
approved these changes
Aug 9, 2019
| """ | ||
|
|
||
| with gfile.GFile(filename) as f: | ||
| tree = ET.parse(f) | ||
|
|
||
| root = tree.getroot() | ||
| image_filename = root.find('filename').text |
There was a problem hiding this comment.
can we be guaranteed this will be found?
There was a problem hiding this comment.
Image labeling tools that support the PASCAL VOC format should include the source image 'filename' in the output annotation XML file. If the 'filename' element is not found then this function will throw an exception.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug in
annotation.read_from_pascalwhere the image filename is ignored, resulting one of the callers,dataset.gen_csv_from_annotationsusing the annotation filename instead in the output CSV.This also adds
os.path.expandusercalls whenever a file or directory is read to support home-relative directory paths.Eng. Council bug ID: b/137942099