Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix timestamp when None #232

Merged
merged 1 commit into from
Apr 8, 2019
Merged

Fix timestamp when None #232

merged 1 commit into from
Apr 8, 2019

Conversation

ocervell
Copy link
Contributor

@ocervell ocervell commented Apr 8, 2019

When last_ts is None (no last timestamp for the GSuite Exporter), parser.parse(last_ts) fails with an error. The fix sets the start_time to None when there is no last_ts

@googlebot googlebot added the cla: yes All committers have signed a CLA label Apr 8, 2019
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines. label Apr 8, 2019
AdrienWalkowiak
AdrienWalkowiak approved these changes Apr 8, 2019
View reviewed changes
Copy link
Contributor

@AdrienWalkowiak AdrienWalkowiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

AdrienWalkowiak
AdrienWalkowiak approved these changes Apr 8, 2019
View reviewed changes
Copy link
Contributor

@AdrienWalkowiak AdrienWalkowiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ryanmcdowell ryanmcdowell self-assigned this Apr 8, 2019
@ryanmcdowell ryanmcdowell self-requested a review April 8, 2019 17:25
@ryanmcdowell ryanmcdowell merged commit cfe92cb into GoogleCloudPlatform:master Apr 8, 2019
monobinab pushed a commit to monobinab/professional-services that referenced this pull request Sep 18, 2019
@ryanmcdowell
Merge pull request GoogleCloudPlatform#232 from ocervell/gsuite-expor…
c80254a 
…t-fix-timestamp

Fix timestamp when None
@ocervell ocervell mentioned this pull request Sep 24, 2019
Merged
@ocervell ocervell deleted the gsuite-export-fix-timestamp branch November 3, 2020 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanmcdowell ryanmcdowell ryanmcdowell approved these changes

@AdrienWalkowiak AdrienWalkowiak AdrienWalkowiak approved these changes

Assignees

@ryanmcdowell ryanmcdowell

Labels
cla: yes All committers have signed a CLA size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ocervell @ryanmcdowell @AdrienWalkowiak @googlebot