Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Added Tracking Crypocurrencies Exchange Trades with Google Cloud Platform in Real-Time #191

Merged
merged 11 commits into from
Mar 9, 2019

Conversation

galic1987
Copy link
Contributor

In this solution, we will discuss the most important design and technical decisions: i) how to set up and configure pipeline for ingesting real-time, time-series data from various crypto exchanges ii) how to design suitable data model, which facilitates querying and graphing at scale. Finally, we will provide a tutorial on how to set up and deploy the proposed architecture using GCP. By following the tutorial steps will establish a connection to multiple exchanges, subscribe to their trade feed, extract and transform these trades into a flexible format to be stored in Bigtable and to be graphed and analyzed.

#191 by
dparrish and mbrukman
@galic1987
Copy link
Contributor Author

Changes are implemented - please review , thank you!

@galic1987
Copy link
Contributor Author

Added latest review changes

Copy link
Contributor

@dparrish dparrish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes. Looks good from a Python point of view now.

Copy link

@mbrukman mbrukman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't resolve comment threads without either explaining why it's not necessary, or pushing an update which addresses the comment. Resolving the comment thread looks like it was resolved, when it actually was not addressed at all.

Please re-review all resolved comment threads and address them, e.g., by adding copyright headers, cleaning up code, removing blank lines, etc.

Copy link

@mbrukman mbrukman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks for adding copyright headers everywhere! I have a few more comments which I would like to see fixed before this is finalized, but they're (relatively) minor, so I'm not going to block the merge.

@ryanmcdowell ryanmcdowell self-assigned this Mar 9, 2019
@ryanmcdowell ryanmcdowell merged commit 3b78b6a into GoogleCloudPlatform:master Mar 9, 2019
monobinab pushed a commit to monobinab/professional-services that referenced this pull request Sep 18, 2019
monobinab pushed a commit to monobinab/professional-services that referenced this pull request Sep 18, 2019
Fix: Added Tracking Crypocurrencies Exchange Trades with Google Cloud Platform in Real-Time
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes All committers have signed a CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants