Skip to content

Conversation

@durgesh-ninave-crest
Copy link
Contributor

@durgesh-ninave-crest durgesh-ninave-crest commented Jul 17, 2025

Description

Created samples for Global and Regional Secret Manager API

Samples (Global, Regional)

  1. Create Secret With Labels
  2. Create Secret With Annotations
  3. Edit Secret Labels
  4. Edit Secret Annotations
  5. Delete Secret Label
  6. Delete Secret Annotation
  7. View Secret Labels
  8. View Secret Annotations

Checklist

  • I have followed guidelines from the CONTRIBUTING.MD
  • Appropriate changes to README are included in PR
  • Test passed: ../testing/vendor/bin/phpunit test/ -v
  • Lint passed: php-cs-fixer fix . --config .php-cs-fixer.dist.php
  • These samples need a new API enabled in testing projects to pass (let us know which ones)

Please merge this PR for me once it is approved

@product-auto-label product-auto-label bot added api: secretmanager Issues related to the Secret Manager API. samples Issues that are directly related to samples. labels Jul 17, 2025
@YashSaraf11 YashSaraf11 marked this pull request as ready for review July 18, 2025 06:11
@YashSaraf11 YashSaraf11 requested review from a team as code owners July 18, 2025 06:11
@snippet-bot
Copy link

snippet-bot bot commented Jul 18, 2025

Here is the summary of changes.

You are about to add 16 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@YashSaraf11 YashSaraf11 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 18, 2025
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 18, 2025
@durgesh-ninave-crest durgesh-ninave-crest changed the title feat(secretmanager): Added samples for create secret with labels and annotations feat(secretmanager): Add samples for labels and annotations in Secret Manager Jul 18, 2025
@bshaffer bshaffer merged commit d702269 into GoogleCloudPlatform:main Jul 18, 2025
4 of 11 checks passed
@bshaffer
Copy link
Contributor

I ran the tests and they passed! Great job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: secretmanager Issues related to the Secret Manager API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants