Migrate DLP samples to use regional syntax in parent field #1122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
bshaffer
reviewed
Jun 26, 2020
Contributor
bshaffer
left a comment
bshaffer
left a comment
There was a problem hiding this comment.
One question - Was committing harmful.csv intentional and if so, why?
| @@ -0,0 +1,2 @@ | |||
| Name,Description | |||
Contributor
There was a problem hiding this comment.
Why is this added? This is in GCS
Contributor
Author
There was a problem hiding this comment.
It's in the project used by kokoro, but wasn't in my project so I had to add it before I could properly run tests locally. I can remove it from the PR, it's not needed. (Although it's separately a good idea to either add all the instructions you need to replicate the test env in your own project, or to have the tests themselves push any data into the project that's needed, other langs do it both ways).
Contributor
There was a problem hiding this comment.
gotcha. I don't mind keeping it, just wanted to make sure it was intentional.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update DLP samples to include
locations/globalin the parent field, so that the job name returned by the API matches what is used internally and what is used in the pubsub message being looked for.See internal bug b/158100365
Also added a troubleshooting note to the DLP readme.