Update Cloud KMS samples #1100
Merged
Update Cloud KMS samples #1100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
sethvargo
force-pushed
the
sethvargo/kms_samples
branch
2 times, most recently
from
b4db29b to
52cc6e5
Compare
bshaffer
reviewed
May 4, 2020
| ) { | ||
| // PHP has limited support for asymmetric encryption operations. | ||
| // Specifically, openssl_public_encrypt() does not allow customizing | ||
| // algorithms or padding. Thus, it is not currently possible to use PHP |
Contributor
There was a problem hiding this comment.
This is confusing to me... does KMS require custom algorithms?
Contributor
Author
There was a problem hiding this comment.
Talked on chat. I'm open to other words here.
| private static function runSampleFile($sampleFile, $sampleName, $params = []) | ||
| { | ||
| $sampleFile = __DIR__ . sprintf('/../src/%s', $sampleFile); | ||
| $sampleName = str_replace('_sample', '', $sampleName) . '_sample'; |
Contributor
There was a problem hiding this comment.
What is the purpose of this? As far as I can tell, _sample is never used in the sample name parameter
Contributor
Author
There was a problem hiding this comment.
This entire function is never called directly (only runSample). It's a lower-level API that someone can call when the name of the file doesn't match the name of the sample.
dwsupplee
suggested changes
May 4, 2020
Contributor
dwsupplee
left a comment
dwsupplee
left a comment
There was a problem hiding this comment.
These looks really nice @sethvargo, nice work.
sethvargo
force-pushed
the
sethvargo/kms_samples
branch
from
6e530cf to
cef66da
Compare
sethvargo
force-pushed
the
sethvargo/kms_samples
branch
from
cef66da to
08e0ede
Compare
sethvargo
force-pushed
the
sethvargo/kms_samples
branch
from
08e0ede to
72b93b8
Compare
dwsupplee
approved these changes
May 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the Cloud KMS samples to match the other languages (sans Ruby and Python which are still on my list). It uses the new sample format Brent and I discussed on chat.