Skip to content
This repository was archived by the owner on Oct 19, 2023. It is now read-only.

Adding version 7.4.12 #526

Merged
merged 1 commit into from
Dec 1, 2020
Merged

Adding version 7.4.12 #526

merged 1 commit into from
Dec 1, 2020

Conversation

paumas
Copy link
Contributor

@paumas paumas commented Nov 14, 2020

I adding PHP 7.4.12, but i can't check if it works. How I can check?

I don't know how to change recode extension, because PHP 7.4 removed this extension.
https://www.php.net/manual/en/migration74.removed-extensions.php
https://www.php.net/manual/en/recode.installation.php

Note: Recode extension is unbundled and moved to » PECL as of PHP 7.4.0. Consider to use the Multibyte String or iconv extensions instead.

@google-cla
Copy link

google-cla bot commented Nov 14, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Nov 14, 2020
@paumas
Copy link
Contributor Author

paumas commented Nov 14, 2020

@googlebot I signed it!

@google-cla
Copy link

google-cla bot commented Nov 14, 2020

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: yes and removed cla: no labels Nov 14, 2020
@paumas paumas mentioned this pull request Nov 17, 2020
@paumas
Copy link
Contributor Author

paumas commented Nov 25, 2020

@donmccasland can you review my pull request?

@donmccasland
Copy link
Member

Taking a look. Thanks for your work!

Copy link
Member

@donmccasland donmccasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@donmccasland donmccasland merged commit 0a50b38 into GoogleCloudPlatform:master Dec 1, 2020
@paumas paumas deleted the php-7.4 branch December 1, 2020 20:48
@paumas
Copy link
Contributor Author

paumas commented Dec 2, 2020

Thanks @donmccasland. When can I expect release in production?

@donmccasland
Copy link
Member

donmccasland commented Dec 2, 2020 via email

@hussonkevin
Copy link

hussonkevin commented Dec 22, 2020

Hi @donmccasland @paumas ,
Is this PR merged ? Because as you can see in pictures cloud build seems to be based on the 7.3 default. But the Github master branch is the 7.4 as default.
In my composer.json & .lock I have "php": "7.4.*"
Do you know why I cannot get php 7.4.* with Cloudbuild ?

CLOUDBUILD :
cloudbuild

GITHUB :
github

@donmccasland
Copy link
Member

donmccasland commented Dec 28, 2020 via email

@frankieeedeee
Copy link

Hey @donmccasland / @paumas - Has there been any update on the production release of this yet? :)

@paumas
Copy link
Contributor Author

paumas commented Jan 10, 2021

Looks like there are some build errors from the release I kicked off yesterday. I'll post log snippets today and we can start working through them.

On Wed, Dec 2, 2020 at 3:53 AM Paulius Masiliūnas @.***> wrote: Thanks @donmccasland https://github.com/donmccasland. When can I expect release in production? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#526 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAF76UXHI7KZOITAJB6HMUTSSYTEFANCNFSM4TVOBNTQ .

I can't fix build, because @donmccasland don't share log snippets.

@frifrou
Copy link

frifrou commented Jan 25, 2021

Hi @donmccasland,

Any update on this or any idea of the release date :) ?

Cheers

@paumas
Copy link
Contributor Author

paumas commented Mar 29, 2021

Hi @donmccasland,

Can I get google cloud build log file. I can try investigate, what the problem, why not build PHP 7.4 version.

Cheers.

frost-byte pushed a commit to Wiser-Owl/php-docker that referenced this pull request May 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants