-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade google java format for jdk 17 #264
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
For the CLA I think I am covered by the Elastic corporate agreement, but I only visited the page after seeing this an issue, thus maybe the CLA check needs a refresh here. |
/gcbrun |
@SylvainJuge Thanks for the PR !
I re-ran the CLA check, but it is still failing, could you verify that you have taken all the steps mentioned in the details for failed run ? I see the commit you made is associated with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Please take a look at the steps to complete the CLA requirements.
Switching to using my corporate email (and giving up commit signature + email privacy) seems to make the CLA check happy, so at least I have a temporary solution for this 🎉 . Changing the CLA email internally is the long term solution, but this might take a bit of time to get it fixed. |
/gcbrun |
Hi @dashpole could you run |
/gcbrun |
/gcbrun |
The failing cloud function chekd are passing after #270 |
When trying to build the project with JDK 17 and
gradle assemble
, I get the following error message:Just upgrading the google java format to the next version as instructed works.