Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade google java format for jdk 17 #264

Merged
merged 2 commits into from
Nov 16, 2023

Conversation

SylvainJuge
Copy link
Contributor

When trying to build the project with JDK 17 and gradle assemble, I get the following error message:

> You are running Spotless on JVM 17. This requires google-java-format of at least 1.10.0 (you are using 1.9).

Just upgrading the google java format to the next version as instructed works.

@SylvainJuge SylvainJuge requested a review from a team as a code owner October 10, 2023 14:57
@google-cla
Copy link

google-cla bot commented Oct 10, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@dashpole dashpole requested a review from psx95 October 10, 2023 14:59
@SylvainJuge
Copy link
Contributor Author

For the CLA I think I am covered by the Elastic corporate agreement, but I only visited the page after seeing this an issue, thus maybe the CLA check needs a refresh here.

@psx95
Copy link
Contributor

psx95 commented Oct 10, 2023

/gcbrun

@psx95
Copy link
Contributor

psx95 commented Oct 10, 2023

@SylvainJuge Thanks for the PR !

For the CLA I think I am covered by the Elastic corporate agreement, but I only visited the page after seeing this an issue, thus maybe the CLA check needs a refresh here.

I re-ran the CLA check, but it is still failing, could you verify that you have taken all the steps mentioned in the details for failed run ?

I see the commit you made is associated with 763082+SylvainJuge​@users.noreply.github.com which may not be the corporate email you used to register as an authorized contributer.

Copy link
Contributor

@psx95 psx95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Please take a look at the steps to complete the CLA requirements.

@SylvainJuge
Copy link
Contributor Author

Switching to using my corporate email (and giving up commit signature + email privacy) seems to make the CLA check happy, so at least I have a temporary solution for this 🎉 . Changing the CLA email internally is the long term solution, but this might take a bit of time to get it fixed.

@dashpole
Copy link
Contributor

/gcbrun

@SylvainJuge
Copy link
Contributor Author

Hi @dashpole could you run /gcbrun command again ? Thanks a lot for your patience here, I don't see any obvious reason related to my changes why those tests are failing.

@dashpole
Copy link
Contributor

/gcbrun

@psx95
Copy link
Contributor

psx95 commented Nov 16, 2023

/gcbrun

@psx95
Copy link
Contributor

psx95 commented Nov 16, 2023

The failing cloud function chekd are passing after #270

@psx95 psx95 merged commit 2f256a3 into GoogleCloudPlatform:main Nov 16, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants