Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create client on Start instead of Creation #817

Merged
merged 7 commits into from
Mar 13, 2024

Conversation

dashpole
Copy link
Contributor

This unblocks open-telemetry/opentelemetry-collector-contrib#30524 and open-telemetry/opentelemetry-collector-contrib#30527. Components are supposed to perform retry-able steps (which might later succeed), like fetching auth tokens during Start(), rather than during creation. This PR moves getting default credentials and creating clients to the Start() function.

@dashpole dashpole requested a review from a team as a code owner March 12, 2024 14:51
Copy link

codecov bot commented Mar 12, 2024

Codecov Report

Attention: Patch coverage is 20.65217% with 73 lines in your changes are missing coverage. Please review.

Project coverage is 59.93%. Comparing base (0fe89f6) to head (29fc64d).

Files Patch % Lines
exporter/collector/metrics.go 0.00% 40 Missing and 1 partial ⚠️
exporter/collector/logs.go 0.00% 25 Missing ⚠️
exporter/collector/traces.go 63.15% 5 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #817      +/-   ##
==========================================
- Coverage   60.07%   59.93%   -0.14%     
==========================================
  Files          56       56              
  Lines        5854     5886      +32     
==========================================
+ Hits         3517     3528      +11     
- Misses       2186     2205      +19     
- Partials      151      153       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dashpole dashpole merged commit 5476951 into GoogleCloudPlatform:main Mar 13, 2024
30 of 32 checks passed
@dashpole dashpole deleted the client_on_start branch March 13, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants