exporter: add namespace to internal metric label #684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #684 +/- ##
==========================================
- Coverage 69.31% 69.22% -0.09%
==========================================
Files 36 36
Lines 4728 4728
==========================================
- Hits 3277 3273 -4
- Misses 1297 1301 +4
Partials 154 154
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
damemi
approved these changes
Jul 24, 2023
exporter/collector/integrationtest/testdata/fixtures/metrics/untyped_gauge_expect.json
Outdated
Show resolved
Hide resolved
|
The E2E tests have not run because it |
|
/gcbrun |
Signed-off-by: Ridwan Sharif <ridwanmsharif@google.com>
ridwanmsharif
force-pushed
the
ridwanmsharif-rename-untyped-label
branch
from
81eef87
to
8fb73ed
Compare
|
Added the stackdriver-admins team as triagers so your team shouldn't need gcbrun anymore. |
|
(you can ignore codecov) it is informing, but doesn't block merging. I'll leave it to mike to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes the metric label a URI so that OTLP gauges don't accidentally conflict with this label. We will document in the Ops Agent that this is a reserved label key.