This repository was archived by the owner on Jul 16, 2026. It is now read-only.
use path format for public URL#4
Merged
theacodes merged 1 commit intoJun 10, 2015
Merged
Conversation
theacodes
pushed a commit
that referenced
this pull request
Jun 10, 2015
use path format for public URL
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the public URL for a file in GCS to a safer alternative. Bucket names are allowed to hold
.characters, which would result in an incorrect URL. We recently ran into this with gcloud: googleapis/google-cloud-node#638.I'll be sending 2 more PRs for the other branches as well.