Add error handling to composer GCF trigger sample #732
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
ace-n
approved these changes
Sep 7, 2018
| }; | ||
| } | ||
|
|
||
| test.cb.serial(`Does nothing for deleted files`, (t) => { |
| const sample = getSample(); | ||
| sample.mocks.bodyJson.error = expectedMsg; | ||
|
|
||
| sample.program.triggerDag(event, (err, message) => { |
Contributor
There was a problem hiding this comment.
Should we switch to promises at some point? (In a separate PR, of course.)
Contributor
Author
There was a problem hiding this comment.
I didn't realize we could return promises with GCF. Yeah, that'd be ideal.
Contributor
|
Thanks for making this. I think we should consider doing retry on failure in the future as well (maybe someone else can PR that?) We've had issues with execution_date timestamp collisions. |
ace-n
pushed a commit
that referenced
this pull request
Nov 14, 2022
This was referenced Nov 14, 2022
ace-n
pushed a commit
that referenced
this pull request
Nov 21, 2022
ace-n
pushed a commit
that referenced
this pull request
Nov 21, 2022
This was referenced Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressed feedback from bug 111401746.
Please review @TrevorEdwards