Skip to content

s/errors/Error Reporting/ #678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ace-n merged 2 commits into from
Jul 23, 2018
Merged

s/errors/Error Reporting/ #678

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e0823a3
s/errors/Error Reporting/
Jun 27, 2018
00ccb3b
Merge branch 'master' into error-reporting
Jul 20, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions functions/helloworld/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ exports.helloGCSGeneric = (event, callback) => {
* @param {function} callback The callback function.
*/
exports.helloError = (event, callback) => {
// This WILL be reported to Stackdriver errors
// This WILL be reported to Stackdriver Error Reporting
throw new Error('I failed you');
};
// [END functions_helloworld_error]
Expand All @@ -142,7 +142,7 @@ exports.helloError = (event, callback) => {
* @param {function} callback The callback function.
*/
exports.helloError2 = (event, callback) => {
// This will NOT be reported to Stackdriver errors
// This will NOT be reported to Stackdriver Error Reporting
throw 1;
};
// [END functions_helloworld_error_2]
Expand Down